linux-kernel - Re: [PATCH v2] crypto: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6iByA35mExfmwGa@gondor.apana.org.au>
Date: Sun, 9 Feb 2025 18:22:00 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Horia Geantă <horia.geanta@....com>,
	Pankaj Gupta <pankaj.gupta@....com>,
	Gaurav Jain <gaurav.jain@....com>,
	Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Arnaud Ebalard <arno@...isbad.org>,
	Srujana Challa <schalla@...vell.com>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, qat-linux@...el.com
Subject: Re: [PATCH v2] crypto: Use str_enable_disable-like helpers

On Tue, Jan 14, 2025 at 08:05:01PM +0100, Krzysztof Kozlowski wrote:
> Replace ternary (condition ? "enable" : "disable") syntax with helpers
> from string_choices.h because:
> 1. Simple function call with one argument is easier to read.  Ternary
>    operator has three arguments and with wrapping might lead to quite
>    long code.
> 2. Is slightly shorter thus also easier to read.
> 3. It brings uniformity in the text - same string.
> 4. Allows deduping by the linker, which results in a smaller binary
>    file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes in v2:
> 1. Also: drivers/crypto/caam/caamalg_qi2.c
> ---
>  drivers/crypto/bcm/cipher.c                         |  3 ++-
>  drivers/crypto/bcm/spu2.c                           |  3 ++-
>  drivers/crypto/caam/caamalg_qi2.c                   |  3 ++-
>  drivers/crypto/intel/qat/qat_common/adf_sysfs.c     | 10 +++-------
>  drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c   |  5 +++--
>  drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c |  3 ++-
>  6 files changed, 14 insertions(+), 13 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt