linux-kernel - Re: [PATCH 11/13] x86/virt/tdx: Add SEAMCALL wrappers for TD measurement of initial contents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a15e3c82-56a4-4dc8-9b9c-cdc641fa7b6f@intel.com>
Date: Tue, 14 Jan 2025 14:10:14 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>,
 "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "Zhao, Yan Y" <yan.y.zhao@...el.com>,
 "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
 "Huang, Kai" <kai.huang@...el.com>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
 "Yamahata, Isaku" <isaku.yamahata@...el.com>
Subject: Re: [PATCH 11/13] x86/virt/tdx: Add SEAMCALL wrappers for TD
 measurement of initial contents

On 1/14/25 14:03, Paolo Bonzini wrote:
> On 1/3/25 19:02, Edgecombe, Rick P wrote:
>>> +u64 tdh_mr_extend(struct tdx_td *td, u64 gpa, u64 *rcx, u64 *rdx)
>>
>> gpa should be type gpa_t to avoid bare u64 types.
> 
> gpa_t is defined in kvm_types.h, I am not sure arch/x86/virt should
> include it.

Yeah, _ideally_ we'd just keep it one type across the stack, but I can
understand why the KVM folks wouldn't want it to leave KVM-specific code.

My biggest beef elsewhere was with the indiscriminate use of u64. Using
it for passing a gpa which is also 64-bits is far from indiscriminate.
It's fine.