linux-kernel - Re: [PATCH v3 00/10] DTS updates for system1 BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8fa4a3d-9cbc-49ce-9d76-85e57453fb04@linux.ibm.com>
Date: Tue, 14 Jan 2025 16:09:57 -0600
From: Ninad Palsule <ninad@...ux.ibm.com>
To: Rob Herring <robh@...nel.org>
Cc: linux-aspeed@...ts.ozlabs.org, davem@...emloft.net, edumazet@...gle.com,
        andrew@...econstruct.com.au, netdev@...r.kernel.org, kuba@...nel.org,
        joel@....id.au, linux-arm-kernel@...ts.infradead.org,
        openipmi-developer@...ts.sourceforge.net, conor+dt@...nel.org,
        linux-kernel@...r.kernel.org, pabeni@...hat.com,
        ratbert@...aday-tech.com, eajames@...ux.ibm.com,
        devicetree@...r.kernel.org, andrew+netdev@...n.ch, minyard@....org,
        krzk+dt@...nel.org
Subject: Re: [PATCH v3 00/10] DTS updates for system1 BMC

Hello Rob,

On 1/13/25 18:07, Rob Herring wrote:
>>> My bot found new DTB warnings on the .dts files added or changed in this
>>> series.
>>>
>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>> are fixed by another series. Ultimately, it is up to the platform
>>> maintainer whether these warnings are acceptable or not. No need to reply
>>> unless the platform maintainer has comments.
>>>
>>> If you already ran DT checks and didn't see these error(s), then
>>> make sure dt-schema is up to date:
>>>
>>>     pip3 install dtschema --upgrade
>>>
>>>
>>> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20250108163640.1374680-1-ninad@...ux.ibm.com:
>>>
>>> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: gpio@...80000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of the regexes: 'pinctrl-[0-9]+'
>>> 	from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
>> This is a false positive. So ignoring it.
> No, it is not. You need to define hog nodes in aspeed,ast2400-gpio.yaml.
> See other GPIO controller bindings that do this.

ok, I fixed it. Thanks for the review.

Regards,

Ninad

>
> Rob