linux-kernel - Re: [RFC PATCH] soc: audio-graph-card2: use correct endpoint when getting link parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xmhj6s0.wl-kuninori.morimoto.gx@renesas.com>
Date: Tue, 14 Jan 2025 23:49:04 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
 tony@...mide.com, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] soc: audio-graph-card2: use correct endpoint when getting link parameters

Hi Ivaylo

Thank you for clarify your situation.

> > You want to parse "remote" endpoint (= rep) directly, but the function
> > requests "port" (= rport), and it will use endpoint0 ( != rep).
> > Is this the main issue you want to fix ?
> > 
> 
> Yes, it is the 'remote' side endpoint, currently it is always remote 
> endpoint0 that is used, because when you get 'port', it is endpoint0 of 
> that port that core uses.

OK, I could understand, and I can agree to your idea.
Getting "port" from "endpoint" is always stable, but getting "endpoint"
from "port" without parameter will be issue, indeed.

But I guess your original patch is based on very old kernel ?
It can't be applied to Mark's for-6.14 branch as-is.
Please based on latest branch.

And about git-comment,

	When link parameters are parsed, it is always endpoint@0 that is used and
	parameters set to other endpoints are ignored.

Please indicate that current function requests "port" as parameter,
thus, it always selects endpoint0, etc. That is easy to understand.

Thank you for your help !!

Best regards
---
Kuninori Morimoto