linux-kernel - Re: [RFC PATCH] soc: audio-graph-card2: use correct endpoint when getting link parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2a019da-b8db-4976-8cbe-bbbfac771d38@gmail.com>
Date: Wed, 15 Jan 2025 08:10:03 +0200
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
 tony@...mide.com, alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] soc: audio-graph-card2: use correct endpoint when
 getting link parameters

Hi Morimoto-san,

On 15.01.25 г. 1:49 ч., Kuninori Morimoto wrote:
> 
> Hi Ivaylo
> 
> Thank you for clarify your situation.
> 
>>> You want to parse "remote" endpoint (= rep) directly, but the function
>>> requests "port" (= rport), and it will use endpoint0 ( != rep).
>>> Is this the main issue you want to fix ?
>>>
>>
>> Yes, it is the 'remote' side endpoint, currently it is always remote
>> endpoint0 that is used, because when you get 'port', it is endpoint0 of
>> that port that core uses.
> 
> OK, I could understand, and I can agree to your idea.
> Getting "port" from "endpoint" is always stable, but getting "endpoint"
> from "port" without parameter will be issue, indeed.
> 
> But I guess your original patch is based on very old kernel ?
> It can't be applied to Mark's for-6.14 branch as-is.
> Please based on latest branch.
> 

Yes, it is based in 6.6, that's why I sent RFC patch, as rebasing will 
not be trivial and I didn't want to spend time on something that could 
possibly be rejected.

> And about git-comment,
> 
> 	When link parameters are parsed, it is always endpoint@0 that is used and
> 	parameters set to other endpoints are ignored.
> 
> Please indicate that current function requests "port" as parameter,
> thus, it always selects endpoint0, etc. That is easy to understand.
> 

Ok, will do.

Thanks!
Ivo