linux-kernel - Re: [PATCH 3/3] arm64: dts: mediatek: add device-tree for Genio 510 EVK board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c041b875-23a6-4e0a-a31a-40bee27b62b5@collabora.com>
Date: Tue, 14 Jan 2025 11:32:23 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Sean Wang <sean.wang@...iatek.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH 3/3] arm64: dts: mediatek: add device-tree for Genio 510
 EVK board

Il 14/01/25 08:38, Louis-Alexis Eyraud ha scritto:
> This commit adds a basic device-tree (mt8370-genio-510-evk.dts) in
> order to be able to boot the Genio 510 EVK board, based on MediaTek
> MT8370 SoC and very close to the Genio 700 EVK board. It also
> splits mt8390-genio-700-evk.dts file in two to create
> mt8390-genio-common.dtsi include file, containing common definitions
> for both boards.
> 

Please split this commit in two parts (and rename the suggested commit
titles as you wish):
  1. arm64: dts: mediatek: mt8390-genio-700-evk: Move common parts to dtsi
     (in preparation for introducing support for genio 510 evk, blahblah)
  2. arm64: dts: mediatek: Add device-tree for Genio 510 EVK

This makes the patches a bit more readable and, if anything happens, whoever
looks at the commit history will be able to more immediately understand what's
actually going on :-)

Cheers,
Angelo

> The Genio 510 EVK has following features:
> - MT8370 SoC
> - MT6365 PMIC
> - MT6319 Buck IC
> - 4GB LPDDR4X
> - 64GB eMMC 5.1
> - 12V DC Jack
> - Micro SD card slot
> - Push Button x 4 (Power, Reset, Download and Home Key)
> - LED x 4 (Power, Reset, System on and Charging Status)
> - USB Device Port x 1 (Micro USB Connector)
> - USB Host Port x 1 (Type-C USB Connector)
> - 3.5mm Earphone Jack x 1 (with Microphone Input)
> - 3.5mm Line Out Audio Jack x 1
> - Analog Microphone x 1
> - Digital Microphone x 2
> - Gigabit Ethernet with RJ45 connector
> - HDMI 2.0 TX port with Type A HDMI connector
> - eDP port
> - 3x UART with serial-to-usb converters and micro USB connectors
> - M.2 Slot x 2
> - I2C Capacitive Touch Pad
> - 4-Lane DSI x 2
> - 4-Data Lane CSI x 2
> - I2S Pin header
> - 40-Pin 2.54mm Pin Header x 1
> 
> Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
> ---
>   arch/arm64/boot/dts/mediatek/Makefile              |    1 +
>   .../boot/dts/mediatek/mt8370-genio-510-evk.dts     |   19 +
>   .../boot/dts/mediatek/mt8390-genio-700-evk.dts     | 1033 +------------------
>   .../boot/dts/mediatek/mt8390-genio-common.dtsi     | 1040 ++++++++++++++++++++
>   4 files changed, 1061 insertions(+), 1032 deletions(-)
>