linux-kernel - Re: [PATCH v1 1/3] drm/admgpu: replace kmalloc() and memcpy() with kmemdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173685063900.121209.12260311689704122686.b4-ty@kernel.org>
Date: Tue, 14 Jan 2025 11:30:39 +0100
From: Carlos Maiolino <cem@...nel.org>
To: Alex Deucher <alexander.deucher@....com>, 
 Victor Skvortsov <victor.skvortsov@....com>, amd-gfx@...ts.freedesktop.org, 
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
 Mirsad Todorovac <mtodorovac69@...il.com>
Cc: Christian König <christian.koenig@....com>, 
 Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, 
 Simona Vetter <simona@...ll.ch>, Zhigang Luo <Zhigang.Luo@....com>, 
 Hawking Zhang <Hawking.Zhang@....com>, Lijo Lazar <lijo.lazar@....com>, 
 Yunxiang Li <Yunxiang.Li@....com>, Jack Xiao <Jack.Xiao@....com>, 
 Vignesh Chander <Vignesh.Chander@....com>, 
 Danijel Slivka <danijel.slivka@....com>
Subject: Re: [PATCH v1 1/3] drm/admgpu: replace kmalloc() and memcpy() with
 kmemdup()

On Tue, 17 Dec 2024 23:58:10 +0100, Mirsad Todorovac wrote:
> The static analyser tool gave the following advice:
> 
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:1266:7-14: WARNING opportunity for kmemdup
> 
>  → 1266         tmp = kmalloc(used_size, GFP_KERNEL);
>    1267         if (!tmp)
>    1268                 return -ENOMEM;
>    1269
>  → 1270         memcpy(tmp, &host_telemetry->body.error_count, used_size);
> 
> [...]

Applied to for-next, thanks!

[1/3] drm/admgpu: replace kmalloc() and memcpy() with kmemdup()
      (no commit info)
[2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()
      commit: 9d9b72472631262b35157f1a650f066c0e11c2bb
[3/3] btrfs: replace kmalloc() and memcpy() with kmemdup()
      (no commit info)

Best regards,
-- 
Carlos Maiolino <cem@...nel.org>