linux-kernel - Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVKRJ4z-s6hF+=RyMk70n_TU8fQ4tu6A4NVzQPgakMBsQ@mail.gmail.com>
Date: Tue, 14 Jan 2025 11:52:14 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Clément Léger <cleger@...osinc.com>, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property_present() for
 non-boolean properties

Hi Rob,

Thanks for your patch!

On Tue, Dec 31, 2024 at 5:14 PM Rob Herring (Arm) <robh@...nel.org> wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.

Please add

    This gets rid of the following boot warnings:

        OF: /cpus/cpu@0: Read of boolean property 'i-cache-size' with a value.
        OF: /cpus/cpu@0: Read of boolean property 'd-cache-size' with a value.
        OF: /soc/cache-controller@...00000: Read of boolean property
'cache-size' with a value.

so the next person doesn't have to dive into the code to find this patch ;-)

> Reviewed-by: Clément Léger <cleger@...osinc.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds