linux-kernel - Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJPHOv5355tD40B7zgFpRJ4BAoM-d6fQOaKKFWJ0-9fuQ@mail.gmail.com>
Date: Tue, 14 Jan 2025 09:25:52 -0600
From: Rob Herring <robh@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Clément Léger <cleger@...osinc.com>, 
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property_present() for
 non-boolean properties

On Tue, Jan 14, 2025 at 4:52 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Rob,
>
> Thanks for your patch!
>
> On Tue, Dec 31, 2024 at 5:14 PM Rob Herring (Arm) <robh@...nel.org> wrote:
> > The use of of_property_read_bool() for non-boolean properties is
> > deprecated in favor of of_property_present() when testing for property
> > presence.
>
> Please add
>
>     This gets rid of the following boot warnings:
>
>         OF: /cpus/cpu@0: Read of boolean property 'i-cache-size' with a value.
>         OF: /cpus/cpu@0: Read of boolean property 'd-cache-size' with a value.
>         OF: /soc/cache-controller@...00000: Read of boolean property
> 'cache-size' with a value.
>
> so the next person doesn't have to dive into the code to find this patch ;-)

If this patch had been picked up in a timely manner, no one would have
ever seen that warning. I'll leave it to the riscv maintainers to add
that if they desire. That warning didn't exist when this patch was
written.

Rob