linux-kernel - Re: [PATCH v5 -next 00/16] sysctl: move sysctls from vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2asuqwd4rpml6ylxce7mpz2vpvlm2gpdtwpp4lwuf4mdlylig2@dxdj4a73x2sb>
Date: Tue, 14 Jan 2025 14:50:12 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Kaixiong Yu <yukaixiong@...wei.com>
Cc: akpm@...ux-foundation.org, mcgrof@...nel.org, 
	ysato@...rs.sourceforge.jp, dalias@...c.org, glaubitz@...sik.fu-berlin.de, luto@...nel.org, 
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, 
	hpa@...or.com, viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, 
	kees@...nel.org, j.granados@...sung.com, willy@...radead.org, 
	Liam.Howlett@...cle.com, vbabka@...e.cz, lorenzo.stoakes@...cle.com, trondmy@...nel.org, 
	anna@...nel.org, chuck.lever@...cle.com, jlayton@...nel.org, neilb@...e.de, 
	okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, paul@...l-moore.com, 
	jmorris@...ei.org, linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-nfs@...r.kernel.org, 
	netdev@...r.kernel.org, linux-security-module@...r.kernel.org, dhowells@...hat.com, 
	haifeng.xu@...pee.com, baolin.wang@...ux.alibaba.com, shikemeng@...weicloud.com, 
	dchinner@...hat.com, bfoster@...hat.com, souravpanda@...gle.com, hannes@...xchg.org, 
	rientjes@...gle.com, pasha.tatashin@...een.com, david@...hat.com, 
	ryan.roberts@....com, ying.huang@...el.com, yang@...amperecomputing.com, 
	zev@...ilderbeest.net, serge@...lyn.com, vegard.nossum@...cle.com, 
	wangkefeng.wang@...wei.com
Subject: Re: [PATCH v5 -next 00/16] sysctl: move sysctls from vm_table into
 its own files

On Sat, Jan 11, 2025 at 03:07:35PM +0800, Kaixiong Yu wrote:
> This patch series moves sysctls of vm_table in kernel/sysctl.c to
> places where they actually belong, and do some related code clean-ups.
> After this patch series, all sysctls in vm_table have been moved into its
> own files, meanwhile, delete vm_table.
> 
> All the modifications of this patch series base on
> linux-next(tags/next-20250110). To test this patch series, the code was
> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
> x86_64 architectures. After this patch series is applied, all files
> under /proc/sys/vm can be read or written normally.

It is looking good! Here is how I think we should move it upstream:

1. These should queued in for 6.15 instead of the next merge window.
   It is too late in the current cycle and if we put it in now, it will
   not properly tested in linux-next.

2. I am putting this in sysctl-testing with the expectation of pushing this
   up for the 6.15 merge window. Please tell me if you want this to go
   through some other tree.

Thx for the contribution

Best
> 
> my test steps as below listed:
> 
> Step 1: Set CONFIG_SYSCTL to 'n' and compile the Linux kernel on the
> arm64 architecture. The kernel compiles successfully without any errors
> or warnings.
> 
...
>  mm/swap.c                          |  16 ++-
>  mm/swap.h                          |   1 +
>  mm/util.c                          |  67 +++++++--
>  mm/vmscan.c                        |  23 +++
>  mm/vmstat.c                        |  44 +++++-
>  net/sunrpc/auth.c                  |   2 +-
>  security/min_addr.c                |  11 ++
>  23 files changed, 336 insertions(+), 312 deletions(-)
> 
> -- 
> 2.34.1
> 

-- 

Joel Granados