linux-kernel - Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4fq6XU650iOsFZe@ryzen>
Date: Wed, 15 Jan 2025 18:05:45 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Hans Zhang <18255117159@....com>, kw@...ux.com, kishon@...nel.org,
	arnd@...db.de, gregkh@...uxfoundation.org,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	rockswang7@...il.com
Subject: Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size

Hello Hans,

On Wed, Jan 15, 2025 at 10:28:42PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Jan 09, 2025 at 05:45:56PM +0800, Hans Zhang wrote:
> > With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
> > 
> > The return value of the `pci_resource_len` interface is not an integer.
> > Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
> > overflow.
> > 
> > Change the data type of bar_size from integer to resource_size_t, to fix
> > the above issue.
> > 
> > Signed-off-by: Hans Zhang <18255117159@....com>
> > Suggested-by: Niklas Cassel <cassel@...nel.org>

I intended to stay silent, but considering that Mani gave additional
feedback:

- The Suggested-by tag should be in patch 1/2, not 2/2 :)
  (Patch 2/2 was 100% you.)

- No need to keep the change log all the way back since V1, usually
  people just keep the change log since the last revision.


Kind regards,
Niklas