linux-kernel - Re: [PATCH v4] tools/rtla: Add osnoise_trace_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <099e9ae9-5d36-46bb-8790-1b6a33dc1448@stanley.mountain>
Date: Wed, 15 Jan 2025 21:40:40 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
	Daniel Bristot de Oliveira <bristot@...nel.org>,
	John Kacur <jkacur@...hat.com>,
	"Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
	Eder Zulian <ezulian@...hat.com>, Tomas Glozar <tglozar@...hat.com>,
	Gabriele Monaco <gmonaco@...hat.com>,
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] tools/rtla: Add osnoise_trace_is_off()

On Wed, Jan 15, 2025 at 07:58:30PM +0200, Costa Shulyupin wrote:
> The original code accidentally works because offset of
> `record->trace` is zero.

It doesn't "accidentally work".  The people who write this kind of
code 100% understand what they are doing.  They don't see it as
anything complicated.

regards,
dan carpenter