linux-kernel - Re: [PATCH net v2] net: appletalk: Drop aarp_send_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250115140629.1c37c8a2@kernel.org>
Date: Wed, 15 Jan 2025 14:06:29 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yeking@...54.com
Cc: arnd@...db.de, davem@...emloft.net, edumazet@...gle.com,
 gregkh@...uxfoundation.org, horms@...nel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, prarit@...hat.com,
 vkuznets@...hat.com
Subject: Re: [PATCH net v2] net: appletalk: Drop aarp_send_probe_phase1()

On Mon, 13 Jan 2025 09:44:51 +0000 Yeking@...54.com wrote:
>  void aarp_probe_network(struct atalk_iface *atif)
>  {
> -	if (atif->dev->type == ARPHRD_LOCALTLK ||
> -	    atif->dev->type == ARPHRD_PPP)
> -		aarp_send_probe_phase1(atif);
> -	else {
> +	if (atif->dev->type != ARPHRD_LOCALTLK &&
> +	    atif->dev->type != ARPHRD_PPP) {
>  		unsigned int count;

You assert this is our only option, so why leave the if () around 
at all?

nit: subject prefix should be "PATCH net-next v2"
-- 
pw-bot: cr