linux-kernel - Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <848b4dad4f38dc6545b97f7c5007e514.sboyd@kernel.org>
Date: Wed, 15 Jan 2025 15:16:10 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, Konrad Dybcio <konradybcio@...il.com>, Konrad Dybcio <konradybcio@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>, linux-kernel@...r.kernel.org, Bjorn Andersson <bjorn.andersson@....qualcomm.com>, Abel Vesa <abel.vesa@...aro.org>, Johan Hovold <johan+linaro@...nel.org>, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v2] spmi: Fix controller->node != parent->node breakage

Quoting Konrad Dybcio (2025-01-14 12:37:20)
> On 1/14/25 19:30, Stephen Boyd wrote:
> > 
> > Ok, I see that I was reading the already reverted state of the tree
> > where the 'ctrl->dev.of_node = node' assignment came back. So there's
> > nothing to do besides drop the patch in fixes, which I already did. We
> > can then apply this patch to drop the duplicate assignment as a cleanup
> > and to avoid a refcount bump on the of_node that isn't needed.
> > 
> > ----8<---
> > diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
> > index 3cafdf22c909..122140b97579 100644
> > --- a/drivers/spmi/hisi-spmi-controller.c
> > +++ b/drivers/spmi/hisi-spmi-controller.c
> > @@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
> >   
> >       spin_lock_init(&spmi_controller->lock);
> >   
> > -     ctrl->dev.parent = pdev->dev.parent;
> > -     ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
> > -
> >       /* Callbacks */
> >       ctrl->read_cmd = spmi_read_cmd;
> >       ctrl->write_cmd = spmi_write_cmd;
> 
> That works for me, thank you
> 

Joe, care to send this patch to replace the one you sent previously?