| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <73lfadj2ss27z3p2u3cknvymnkdiuq5g775armqf4w25h6q372@bzlsbnakclqu>
Date: Wed, 15 Jan 2025 09:10:25 +0800
From: "Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>, Peter Zijlstra <peterz@...radead.org>,
Greg KH <gregkh@...uxfoundation.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
Jiri Kosina <jikos@...nel.org>
Subject: Re: [PATCH v2] iio: hid-sensor-attributes: validate sensitivity
attributes
On Tue, Jan 14, 2025 at 09:12:54AM -0800, srinivas pandruvada wrote:
> On Tue, 2025-01-14 at 05:28 -0800, srinivas pandruvada wrote:
> > On Tue, 2025-01-14 at 15:02 +0800, Chia-Lin Kao (AceLan) wrote:
> > > An invalid sensor device was observed in HP 5MP Camera (USB ID
> > > 0408:5473)
> > > which provided valid index and report_ids for poll, report_state
> > > and
> > > power_state attributes, but had invalid report_latency,
> > > sensitivity,
> > > and
> > > timestamp attributes. This would cause the system to hang when
> > > using
> > > iio_info to access attributes, as runtime PM tried to wake up an
> > > unresponsive sensor.
> > >
> > > Fix this by validating both sensitivity.index and
> > > sensitivity_rel.index
> > > during sensor probe. Since valid sensors must initialize these with
> > > non-negative values, reject the sensor if either index is negative.
> > >
> >
> > These are optional fields by spec. So we can't reject sensor. I worry
> > that this will cause more regressions.
> >
> > We will need a blocked list. We don't process "Persistent Unique ID"
> > or
> > "Sensor Manufacturer/Model". Please check if the report descriptors
> > have any of these fields described in section 1.5 of spec.
> >
> > >
> We probably may not be able to read the above features, I suggest add
> this device Vendor=0408 ProdID=5473
> hid_ignore_list[].
Yes, this works for me, too.
I'll go with this way and submit another patch later.
>
> Thanks,
> Srinivas
>
>
>
> > > [ 2.594565] [453] hid-sensor-hub 0003:0408:5473.0003: Report
> > > latency attributes: ffffffff:ffffffff
> > > [ 2.594573] [453] hid-sensor-hub 0003:0408:5473.0003: common
> > > attributes: 5:1, 2:1, 3:1 ffffffff:ffffffff ffffffff:ffffffff
> > > [ 2.595485] [453] hid-sensor-hub 0003:0408:5473.0003: Report
> > > latency attributes: ffffffff:ffffffff
> > > [ 2.595492] [453] hid-sensor-hub 0003:0408:5473.0003: common
> > > attributes: 5:11, 3:11, 1:11 ffffffff:ffffffff ffffffff:ffffffff
> > >
> > > T: Bus=03 Lev=01 Prnt=01 Port=03 Cnt=01 Dev#= 2 Spd=480 MxCh= 0
> > > D: Ver= 2.01 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1
> > > P: Vendor=0408 ProdID=5473 Rev=00.07
> > > S: Manufacturer=Quanta
> > > S: Product=HP 5MP Camera
> > > S: SerialNumber=01.00.00
> > > C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> > > I: If#= 0 Alt= 0 #EPs= 1 Cls=0e(video) Sub=01 Prot=01
> > > Driver=uvcvideo
> > > E: Ad=87(I) Atr=03(Int.) MxPS= 16 Ivl=16ms
> > > I: If#= 1 Alt= 0 #EPs= 0 Cls=0e(video) Sub=02 Prot=01
> > > Driver=uvcvideo
> > > I: If#= 2 Alt= 0 #EPs= 1 Cls=0e(video) Sub=01 Prot=01
> > > Driver=uvcvideo
> > > E: Ad=85(I) Atr=03(Int.) MxPS= 16 Ivl=16ms
> > > I: If#= 3 Alt= 0 #EPs= 0 Cls=0e(video) Sub=02 Prot=01
> > > Driver=uvcvideo
> > > I: If#= 4 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00
> > > Driver=usbhid
> > > E: Ad=84(I) Atr=03(Int.) MxPS= 64 Ivl=16ms
> > > I: If#= 5 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01
> > > Driver=(none)
> > >
> > > v2. add fixes tag and the device info
> > These change description goes below "---" line.
> >
> > Thanks,
> > Srinivas
> >
> > >
> > > Fixes: bba6d9e47f3e ("iio: hid-sensor-attributes: Fix sensor
> > > property
> > > setting failure.")
> > > Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@...onical.com>
> > > ---
> > > .../hid-sensors/hid-sensor-attributes.c | 23 +++++++++++----
> > > --
> > > --
> > > 1 file changed, 14 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> > > b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> > > index ad1882f608c0..b7ffd97e6c56 100644
> > > --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> > > +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> > > @@ -564,8 +564,21 @@ int hid_sensor_parse_common_attributes(struct
> > > hid_sensor_hub_device *hsdev,
> > > } else
> > > st->timestamp_ns_scale = 1000000000;
> > >
> > > + ret = 0;
> > > + if (st->sensitivity.index < 0 || st->sensitivity_rel.index
> > > <
> > > 0) {
> > > + ret = -EINVAL;
> > > + goto out;
> > > + }
> > > +
> > > hid_sensor_get_report_latency_info(hsdev, usage_id, st);
> > >
> > > + ret = sensor_hub_get_feature(hsdev,
> > > + st->power_state.report_id,
> > > + st->power_state.index,
> > > sizeof(value), &value);
> > > + if (value < 0)
> > > + ret = -EINVAL;
> > > +
> > > +out:
> > > hid_dbg(hsdev->hdev, "common attributes: %x:%x, %x:%x,
> > > %x:%x
> > > %x:%x %x:%x\n",
> > > st->poll.index, st->poll.report_id,
> > > st->report_state.index, st-
> > > >report_state.report_id,
> > > @@ -573,15 +586,7 @@ int hid_sensor_parse_common_attributes(struct
> > > hid_sensor_hub_device *hsdev,
> > > st->sensitivity.index, st->sensitivity.report_id,
> > > timestamp.index, timestamp.report_id);
> > >
> > > - ret = sensor_hub_get_feature(hsdev,
> > > - st->power_state.report_id,
> > > - st->power_state.index,
> > > sizeof(value), &value);
> > > - if (ret < 0)
> > > - return ret;
> > > - if (value < 0)
> > > - return -EINVAL;
> > > -
> > > - return 0;
> > > + return ret;
> > > }
> > > EXPORT_SYMBOL_NS(hid_sensor_parse_common_attributes, "IIO_HID");
> > >
> >
>
Powered by blists - more mailing lists