linux-kernel - Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a90f92e4c72b7c11f3e44d885aaf69d16eed3f9.camel@mediatek.com>
Date: Wed, 15 Jan 2025 11:05:00 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"bvanassche@....org" <bvanassche@....org>, "quic_nguyenb@...cinc.com"
	<quic_nguyenb@...cinc.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "avri.altman@....com" <avri.altman@....com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"beanhuo@...ron.com" <beanhuo@...ron.com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "daejun7.park@...sung.com"
	<daejun7.park@...sung.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux@...ck-us.net" <linux@...ck-us.net>
Subject: Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit
 Definitions

On Mon, 2025-01-13 at 10:32 -0800, Bao D. Nguyen wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
> 
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature
> notification support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@...cinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@....com>
> ---
>  include/ufs/ufs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
> 
>  /* Possible values for dExtendedUFSFeaturesSupport */
>  enum {
> -       UFS_DEV_LOW_TEMP_NOTIF          = BIT(4),
> -       UFS_DEV_HIGH_TEMP_NOTIF         = BIT(5),
> +       UFS_DEV_HIGH_TEMP_NOTIF         = BIT(4),
> +       UFS_DEV_LOW_TEMP_NOTIF          = BIT(5),
>         UFS_DEV_EXT_TEMP_NOTIF          = BIT(6),
>         UFS_DEV_HPB_SUPPORT             = BIT(7),
>         UFS_DEV_WRITE_BOOSTER_SUP       = BIT(8),
> --
> 2.7.4
> 

Hi Bao,

Thanks for fix this bug.

Reviewed-by: Peter Wang <peter.wang@...iatek.com>