linux-kernel - Re: [PATCH 2/5] dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16f40c7c5d6417d1ae0f687b4954e26cbe36a0f4.camel@nvidia.com>
Date: Wed, 15 Jan 2025 11:41:43 +0000
From: Kartik Rajput <kkartik@...dia.com>
To: "thierry.reding@...il.com" <thierry.reding@...il.com>
CC: Laxman Dewangan <ldewangan@...dia.com>, Jon Hunter <jonathanh@...dia.com>,
	Akhil R <akhilrajeev@...dia.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "robh@...nel.org" <robh@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "andi.shyti@...nel.org"
	<andi.shyti@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "digetx@...il.com"
	<digetx@...il.com>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: i2c: nvidia,tegra20-i2c: Document
 Tegra264 I2C

On Wed, 2025-01-08 at 17:47 +0100, Thierry Reding wrote:
> On Wed, Jan 08, 2025 at 04:36:17PM +0530, Kartik Rajput wrote:
> > Tegra264 has 17 generic I2C controllers, two of which are in
> > always-on
> > partition of the SoC. In addition to the features supported by
> > Tegra194
> > it also supports a MUTEX register to allow sharing the same I2C
> > instance
> > across multiple firmware.
> > 
> > Document compatible string "nvidia,tegra264-i2c" for Tegra264 I2C.
> > 
> > Signed-off-by: Kartik Rajput <kkartik@...dia.com>
> > ---
> >  .../devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml         | 6
> > ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-
> > i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-
> > i2c.yaml
> > index b57ae6963e62..2a016359328e 100644
> > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > @@ -80,6 +80,12 @@ properties:
> >            support for 64 KiB transactions whereas earlier chips
> > supported no
> >            more than 4 KiB per transactions.
> >          const: nvidia,tegra194-i2c
> > +      - description: |
> > +          Tegra264 has 17 generic I2C controllers, two of which
> > are in the AON
> > +          (always-on) partition of the SoC. In addition to the
> > features from
> > +          T194, a MUTEX register is added to support use of the
> > same I2C
> 
> Maybe spell out Tegra194 above for consistency?
> 
> > +          instance across multiple firmware.
> 
> I don't know if this last sentence makes much sense in a DT bindings
> document, but doesn't hurt either. Maybe s/firmware/firmwares/.
> 
> Thierry

ACK. I will update this in the next patch set.