linux-kernel - Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4ky0iNJ9yE06l3g@smile.fi.intel.com>
Date: Thu, 16 Jan 2025 18:24:50 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs

On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote:
> On Thu, Jan 16, 2025 at 02:43:30PM +0200, Andy Shevchenko wrote:
> > Besides the fact that currently defined devm_*_free() APIs
> > are being unused, it's usually a sign of bad design to call
> > such explicitly. Drop them and make people pay more attention
> > on the misuse of devm_regmap_*() APIs,
> 
> This just seems unhelpful, there's fairly obvious uses for something
> like this where we decide we can't actually use some things based on
> what we discover during probe.

It's an effectively dead code. I rarely see people are using devm_*_free(), and
when it's so, it is most likely by misunderstanding of the concept. For what you
described I don't remember any _practical_ use case. Theoretically any dead code
is useful, but it's not the point, right?

-- 
With Best Regards,
Andy Shevchenko