linux-kernel - Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f001c94-423d-4377-8647-81a41f69d1b2@sirena.org.uk>
Date: Thu, 16 Jan 2025 16:41:36 +0000
From: Mark Brown <broonie@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH v2 1/1] regmap: Drop unused devm_regmap_*_free() APIs

On Thu, Jan 16, 2025 at 06:24:50PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 16, 2025 at 04:15:05PM +0000, Mark Brown wrote:

> > This just seems unhelpful, there's fairly obvious uses for something
> > like this where we decide we can't actually use some things based on
> > what we discover during probe.

> It's an effectively dead code. I rarely see people are using devm_*_free(), and
> when it's so, it is most likely by misunderstanding of the concept. For what you
> described I don't remember any _practical_ use case. Theoretically any dead code
> is useful, but it's not the point, right?

The use case would be to read some ID registers in a subfeature then
decide that it's not supported for some reason so we'll just ignore it
at runtime.  Given that you're also complaining about there being no
current users there doesn't seem to be much problem with misuse.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)