linux-kernel - Re: [PATCH 1/1] seqlock: add missing parameter documentation for raw_seqcount_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c6d1945-aa88-4658-a623-caf5165771b2@redhat.com>
Date: Thu, 16 Jan 2025 14:28:26 -0500
From: Waiman Long <llong@...hat.com>
To: Suren Baghdasaryan <surenb@...gle.com>, akpm@...ux-foundation.org
Cc: sfr@...b.auug.org.au, peterz@...radead.org, mingo@...hat.com,
 will@...nel.org, boqun.feng@...il.com, Liam.Howlett@...cle.com,
 david@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] seqlock: add missing parameter documentation for
 raw_seqcount_try_begin()


On 1/16/25 1:27 PM, Suren Baghdasaryan wrote:
> Add missing documentation for raw_seqcount_try_begin() start parameter.
>
> Fixes: dba4761a3e40 ("seqlock: add raw_seqcount_try_begin")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/all/20250116170522.23e884d5@canb.auug.org.au/
> Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
> ---
> Applies over mm-unstable
>
>   include/linux/seqlock.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> index 22c2c48b4265..b783a3a7ed62 100644
> --- a/include/linux/seqlock.h
> +++ b/include/linux/seqlock.h
> @@ -322,6 +322,7 @@ SEQCOUNT_LOCKNAME(mutex,        struct mutex,    true,     mutex)
>    * raw_seqcount_try_begin() - begin a seqcount_t read critical section
>    *                            w/o lockdep and w/o counter stabilization
>    * @s: Pointer to seqcount_t or any of the seqcount_LOCKNAME_t variants
> + * @start: count to be passed to read_seqcount_retry()
>    *
>    * Similar to raw_seqcount_begin(), except it enables eliding the critical
>    * section entirely if odd, instead of doing the speculation knowing it will
>
> base-commit: 4637fa5d47a49c977116321cc575ea22215df22d

Acked-by: Waiman Long <longman@...hat.com>

The tip tree also has the "seqlock: add raw_seqcount_try_begin" commit 
with a different hash - 96450ead1652.

Cheers, Longman