linux-kernel - Re: [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3933901cddf6c33bbe85e381cae5b3a3.sboyd@kernel.org>
Date: Thu, 16 Jan 2025 14:48:56 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, mchehab+huawei@...nel.org
Cc: linux-kernel@...r.kernel.org, konradybcio@...nel.org, matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com, marijn.suijten@...ainline.org, bjorn.andersson@....qualcomm.com, abel.vesa@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Subject: Re: [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe()

Quoting Joe Hattori (2025-01-15 20:49:07)
> spmi_controller_probe() assigns a parent device and an OF node to an
> SPMI controller. However, the operations are not needed as they are
> already assigned in spmi_controller_alloc(). Thus, remove the duplicated
> assignments. An unnecessary OF node reference acquisition is also
> dropped by this patch.
> 
> Signed-off-by: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
> Suggested-by: Stephen Boyd <sboyd@...nel.org>
> ---

Applied to spmi-next