linux-kernel - [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp>
Date: Thu, 16 Jan 2025 13:49:07 +0900
From: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
To: mchehab+huawei@...nel.org,
	sboyd@...nel.org
Cc: linux-kernel@...r.kernel.org,
	konradybcio@...nel.org,
	matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com,
	marijn.suijten@...ainline.org,
	bjorn.andersson@....qualcomm.com,
	abel.vesa@...aro.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Subject: [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe()

spmi_controller_probe() assigns a parent device and an OF node to an
SPMI controller. However, the operations are not needed as they are
already assigned in spmi_controller_alloc(). Thus, remove the duplicated
assignments. An unnecessary OF node reference acquisition is also
dropped by this patch.

Signed-off-by: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Suggested-by: Stephen Boyd <sboyd@...nel.org>
---
 drivers/spmi/hisi-spmi-controller.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index 3cafdf22c909..122140b97579 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
 
 	spin_lock_init(&spmi_controller->lock);
 
-	ctrl->dev.parent = pdev->dev.parent;
-	ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
-
 	/* Callbacks */
 	ctrl->read_cmd = spmi_read_cmd;
 	ctrl->write_cmd = spmi_write_cmd;
-- 
2.34.1