linux-kernel - Re: [PATCH v2] io_uring/rsrc: Simplify buffer cloning by locking both rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173703681418.10865.3728594442935840848.b4-ty@kernel.dk>
Date: Thu, 16 Jan 2025 07:13:34 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Pavel Begunkov <asml.silence@...il.com>, Jann Horn <jannh@...gle.com>
Cc: io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] io_uring/rsrc: Simplify buffer cloning by locking
 both rings


On Wed, 15 Jan 2025 21:26:03 +0100, Jann Horn wrote:
> The locking in the buffer cloning code is somewhat complex because it goes
> back and forth between locking the source ring and the destination ring.
> 
> Make it easier to reason about by locking both rings at the same time.
> To avoid ABBA deadlocks, lock the rings in ascending kernel address order,
> just like in lock_two_nondirectories().
> 
> [...]

Applied, thanks!

[1/1] io_uring/rsrc: Simplify buffer cloning by locking both rings
      commit: 8865af703c087b8bcc2fdd04b6a93d3cc0fb0e9f

Best regards,
-- 
Jens Axboe