[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <464f2662-cc22-45ac-8f33-99265851c0e7@app.fastmail.com>
Date: Thu, 16 Jan 2025 14:14:19 +0000
From: "Jiaxun Yang" <jiaxun.yang@...goat.com>
To: "Gregory CLEMENT" <gregory.clement@...tlin.com>,
"Aleksandar Rikalo" <arikalo@...il.com>,
"Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
"Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
"Conor Dooley" <conor+dt@...nel.org>
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@...ileye.com>,
Théo Lebrun <theo.lebrun@...tlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@...ileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] MIPS: mobileye: dts: eyeq6h: Enable cluster support
在2025年1月16日一月 下午12:39,Gregory CLEMENT写道:
> Hello Jiaxun,
[...]
>>> + coherency-manager {
>>> + compatible = "mti,eyeq6-cm";
>>
>> ^
>> Maybe compatible = "mti,eyeq6-cm", "mti,mips-cm";
>
> I explicitly makes the compatible "mti,eyeq6-cm" and "mti,mips-cm"
> mutually exclusive. This allows us to require the reg property only for
> "mti,mips-cm" and not have to provide it for "mti,eyeq6-cm".
IMO reg should also be optional for "mti,mips-cm". There is nothing special
for eyeq6 on address probing and so on.
Thanks
--
- Jiaxun
Powered by blists - more mailing lists