linux-kernel - RE: [EXTERNAL] Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR18MB47349A17C33D8665C32513DAC71B2@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Fri, 17 Jan 2025 04:11:32 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>,
        Larysa Zaremba
	<larysa.zaremba@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani
	<hgani@...vell.com>, Sathesh B Edara <sedara@...vell.com>,
        Vimlesh Kumar
	<vimleshk@...vell.com>,
        "thaller@...hat.com" <thaller@...hat.com>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "kheib@...hat.com"
	<kheib@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "einstein.xue@...axg.com"
	<einstein.xue@...axg.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Andrew
 Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: RE: [EXTERNAL] Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats
 locally for persistence

Hi Jakub, Larysa

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Friday, January 17, 2025 5:57 AM
> To: Larysa Zaremba <larysa.zaremba@...el.com>
> Cc: Shinas Rasheed <srasheed@...vell.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Haseeb Gani <hgani@...vell.com>; Sathesh B Edara
> <sedara@...vell.com>; Vimlesh Kumar <vimleshk@...vell.com>;
> thaller@...hat.com; wizhao@...hat.com; kheib@...hat.com;
> konguyen@...hat.com; horms@...nel.org; einstein.xue@...axg.com;
> Veerasenareddy Burru <vburru@...vell.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>
> Subject: [EXTERNAL] Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats
> locally for persistence
> 
> On Thu, 16 Jan 2025 16:26:18 +0100 Larysa Zaremba wrote:
> > > +	for (q = 0; q < oct->num_ioq_stats; q++) {
> > > +		tx_packets += oct->stats_iq[q].instr_completed;
> > > +		tx_bytes += oct->stats_iq[q].bytes_sent;
> > > +		rx_packets += oct->stats_oq[q].packets;
> > > +		rx_bytes += oct->stats_oq[q].bytes;
> >
> > Correct me if I am wrong, but the interface-wide statistics should not change
> > when changing queue number. In such case maybe it would be a good idea
> to
> > always iterate over all OCTEP_MAX_QUEUES queues when calculating the
> stats.
> 
> Good catch!

The queues which are iterated over here refer to the hardware queues, and it is in fact iterating over all the queues.
Can you please clarify more?

Thanks

> --
> pw-bot: cr