linux-kernel - Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116162711.71d74e10@kernel.org>
Date: Thu, 16 Jan 2025 16:27:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Larysa Zaremba <larysa.zaremba@...el.com>
Cc: Shinas Rasheed <srasheed@...vell.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <hgani@...vell.com>, <sedara@...vell.com>,
 <vimleshk@...vell.com>, <thaller@...hat.com>, <wizhao@...hat.com>,
 <kheib@...hat.com>, <konguyen@...hat.com>, <horms@...nel.org>,
 <einstein.xue@...axg.com>, Veerasenareddy Burru <vburru@...vell.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>
Subject: Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for
 persistence

On Thu, 16 Jan 2025 16:26:18 +0100 Larysa Zaremba wrote:
> > +	for (q = 0; q < oct->num_ioq_stats; q++) {
> > +		tx_packets += oct->stats_iq[q].instr_completed;
> > +		tx_bytes += oct->stats_iq[q].bytes_sent;
> > +		rx_packets += oct->stats_oq[q].packets;
> > +		rx_bytes += oct->stats_oq[q].bytes;  
> 
> Correct me if I am wrong, but the interface-wide statistics should not change 
> when changing queue number. In such case maybe it would be a good idea to 
> always iterate over all OCTEP_MAX_QUEUES queues when calculating the stats.

Good catch!
-- 
pw-bot: cr