linux-kernel - Re: [PATCH v2] hv_netvsc: Replace one-element array with flexible array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116161727.19a3bbb0@kernel.org>
Date: Thu, 16 Jan 2025 16:17:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Roman Kisel <romank@...ux.microsoft.com>
Cc: Thorsten Blum <thorsten.blum@...ux.dev>, "K. Y. Srinivasan"
 <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu
 <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 linux-hardening@...r.kernel.org, linux-hyperv@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hv_netvsc: Replace one-element array with flexible
 array member

On Thu, 16 Jan 2025 13:39:52 -0800 Roman Kisel wrote:
> On 1/16/2025 1:19 PM, Thorsten Blum wrote:
> > Replace the deprecated one-element array with a modern flexible array
> > member in the struct nvsp_1_message_send_receive_buffer_complete.
> > 
> > Use struct_size_t(,,1) instead of sizeof() to maintain the same size.  
> 
> Thanks!
> 
> > 
> > Compile-tested only.  
> 
> The code change looks good to me now. I'll build a VM with this change
> to clear my conscience (maybe the change triggers a compiler bug,
> however unlikely that sounds) before replying with any tags. Likely next
> Monday, but feel free to beat me to it, or perhaps, someone else will
> tag this as reviewed by them and/or tested by them.

Doesn't look like a real bug fix, so would be good to get some signal
soon. The merge window is soon so we'll likely close the trees very
very soon ..