[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3b7880c6-2de2-4e68-b247-8c4ace4fc92b@igalia.com>
Date: Fri, 17 Jan 2025 16:31:55 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Tejun Heo <tj@...nel.org>
Cc: void@...ifault.com, arighi@...dia.com, kernel-dev@...lia.com,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] sched_ext: Add an event, SCX_EVENT_RQ_BYPASSING_OPS
Hello,
On 25. 1. 17. 10:41, Tejun Heo wrote:
>> +
>> + /*
>> + * When the bypassing mode is set, the number of bypassed operations.
>> + */
>> + u64 RQ_BYPASSING_OPS;
>> };
>
> I'm not sure this is a particularly good way to account for bypass mode.
> Maybe account the total duration of bypass modes,the number of times it was
> activated and the number of times tasks were dispatched in bypass mode?
I think it is a good idea to further specialize RQ_BYPASSING events.
For the number of times the bypassing mode activated, what about
BYPASS_NR_ACTIVATED?
For the number of task dispatched,what about
BYPASS_NR_TASK_DISPATCHED?
I think BYPASS_NR_ACTIVATED and BYPASS_NR_TASK_DISPATCHED will be
a good proxy for the total duration, so we can skip it until we
have a clear user case. If we need the total duration now (maybe
BYPASS_DURATION?), we can directly measure it in the
scx_ops_bypass() directly. What do you think?
Regards,
Changwoo Min
Powered by blists - more mailing lists