linux-kernel - Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtBxCsyYJjh99vpj+zCtQyPbbHjdo=ucaiL6Nbb08Af3uQ@mail.gmail.com>
Date: Fri, 17 Jan 2025 09:32:43 +0100
From: Vincent Guittot <vincent.guittot@...aro.org>
To: zihan zhou <15645113830zzh@...il.com>
Cc: mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com, 
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com, 
	mgorman@...e.de, vschneid@...hat.com, linux-kernel@...r.kernel.org, 
	zhouzihan30@...com, yaozhenguo <yaozhenguo@...com>, yaowenchao1 <yaowenchao@...com>
Subject: Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu"
 on sched debug

On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@...il.com> wrote:
>
> In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> tasks" table, but not all tasks in the table are runnable.
> It is inappropriate to refer to this table as "runnable tasks", so here it
> is changed to "Tasks on CPU %d", like:

We have used replaced runnable by queued in fair scheduler

>
> Tasks on cpu 31:
>  S            task   PID       vruntime   eligible    deadline
> --------------------------------------------------------------------
>  S        cpuhp/31   173         0.803286   E           2.153245
>  S    migration/31   174         8.167468   E          11.167468
>
> PS For the sake of clarity in reality, some table information has been
> omitted here.
>
>
> Signed-off-by: zihan zhou <15645113830zzh@...il.com>
> Signed-off-by: yaozhenguo <yaozhenguo@...com>
> Signed-off-by: yaowenchao1 <yaowenchao@...com>
> ---
>  kernel/sched/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index a1be00a988bf..687487128400 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -771,7 +771,7 @@ static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
>         struct task_struct *g, *p;
>
>         SEQ_printf(m, "\n");
> -       SEQ_printf(m, "runnable tasks:\n");
> +       SEQ_printf(m, "Tasks on cpu %d:\n", rq_cpu);
>         SEQ_printf(m, " S            task   PID       vruntime   eligible    "
>                    "deadline             slice          sum-exec      switches  "
>                    "prio         wait-time        sum-sleep       sum-block"
> --
> 2.33.0
>