linux-kernel - Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250117113813.GA8603@noisy.programming.kicks-ass.net>
Date: Fri, 17 Jan 2025 12:38:13 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: zihan zhou <15645113830zzh@...il.com>, mingo@...hat.com,
	juri.lelli@...hat.com, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, linux-kernel@...r.kernel.org,
	zhouzihan30@...com, yaozhenguo <yaozhenguo@...com>,
	yaowenchao1 <yaowenchao@...com>
Subject: Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on
 cpu" on sched debug

On Fri, Jan 17, 2025 at 09:32:43AM +0100, Vincent Guittot wrote:
> On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@...il.com> wrote:
> >
> > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> > tasks" table, but not all tasks in the table are runnable.
> > It is inappropriate to refer to this table as "runnable tasks", so here it
> > is changed to "Tasks on CPU %d", like:
> 
> We have used replaced runnable by queued in fair scheduler

Right, but also 'tasks on cpu' is equally wrong -- but really, if you're
looking at sched/debug you have to know what you're doing anyway, so why
bother with trivial stuff like this?

> > Tasks on cpu 31:
> >  S            task   PID       vruntime   eligible    deadline
> > --------------------------------------------------------------------
> >  S        cpuhp/31   173         0.803286   E           2.153245
> >  S    migration/31   174         8.167468   E          11.167468
> >
> > PS For the sake of clarity in reality, some table information has been
> > omitted here.
> >
> >
> > Signed-off-by: zihan zhou <15645113830zzh@...il.com>
> > Signed-off-by: yaozhenguo <yaozhenguo@...com>
> > Signed-off-by: yaowenchao1 <yaowenchao@...com>

And that's a broken SoB chain.