linux-kernel - Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116171653.1f1b6fd4@kernel.org>
Date: Thu, 16 Jan 2025 17:16:53 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Daniel Xu
 <dxu@...uu.xyz>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, Toke Høiland-Jørgensen
 <toke@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, Martin KaFai
 Lau <martin.lau@...ux.dev>, netdev@...r.kernel.org, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from
 netif_receive_skb_list()

On Wed, 15 Jan 2025 16:18:56 +0100 Alexander Lobakin wrote:
> +		empty = __ptr_ring_empty(rcpu->queue);
> +		if (packets += n >= NAPI_POLL_WEIGHT || empty) {

please remove the assignment from the condition