linux-kernel - Re: [PATCH] tools/rtla: Add basic test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250116201808.3c8721c1@gandalf.local.home>
Date: Thu, 16 Jan 2025 20:18:08 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Tomas Glozar <tglozar@...hat.com>
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, John
 Kacur <jkacur@...hat.com>, Luis Goncalves <lgoncalv@...hat.com>, Chang Yin
 <cyin@...hat.com>, Qiao Zhao <qzhao@...hat.com>
Subject: Re: [PATCH] tools/rtla: Add basic test suite

On Thu,  9 Jan 2025 14:38:52 +0100
Tomas Glozar <tglozar@...hat.com> wrote:

> Implement a simple TAP-based test engine in bash and a few basic tests
> using it, to be used to check for bugs and regressions.
> 
> A new "check" target is added to the rtla Makefile that runs the test suite
> using the "prove" command implemented by Test::Harness.
> 
> The only test format currently supported is running rtla with defined
> command arguments per test, checking its exit code. In case the exit
> code is non-zero, the output of rtla is displayed.
> 
> The test cases are adopted from rtla tests in the Continuous Kernel
> Integration (CKI) project [1] with the authors' approval.
> 
> [1] https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests/-/blob/main/rt-tests/us/rtla/
> 
> Signed-off-by: Tomas Glozar <tglozar@...hat.com>

I tested this out, and it failed the last test:

make[1]: Leaving directory '/work/git/linux.git/tools/tracing/rtla'
RTLA=/work/git/linux.git/tools/tracing/rtla/rtla prove -o -f tests/
tests/hwnoise.t ... ok      
tests/osnoise.t ... ok   
tests/timerlat.t .. 9/9 
not ok 9 - hist test in nanoseconds
# 
tests/timerlat.t .. Failed 1/9 subtests 

Test Summary Report
-------------------
tests/timerlat.t (Wstat: 0 Tests: 9 Failed: 1)
  Failed test:  9
Files=3, Tests=20, 451 wallclock secs ( 0.07 usr  0.11 sys + 10.57 cusr 74.09 csys = 84.84 CPU)
Result: FAIL
make: *** [Makefile:89: check] Error 1

-- Steve