linux-kernel - Re: [PATCH v1] selftests/landlock: Fix build with non-default pthread linking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250117.434d5503a465@gnoack.org>
Date: Fri, 17 Jan 2025 13:39:23 +0100
From: Günther Noack <gnoack3000@...il.com>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Günther Noack <gnoack@...gle.com>,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Tahera Fahimi <fahimitahera@...il.com>
Subject: Re: [PATCH v1] selftests/landlock: Fix build with non-default
 pthread linking

On Wed, Jan 15, 2025 at 03:54:07PM +0100, Mickaël Salaün wrote:
> Old toolchains require explicit -lpthread (e.g. on Debian 11).
> 
> Cc: Günther Noack <gnoack@...gle.com>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Tahera Fahimi <fahimitahera@...il.com>
> Fixes: c8994965013e ("selftests/landlock: Test signal scoping for threads")
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>
> ---
>  tools/testing/selftests/landlock/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
> index 348e2dbdb4e0..480f13e77fcc 100644
> --- a/tools/testing/selftests/landlock/Makefile
> +++ b/tools/testing/selftests/landlock/Makefile
> @@ -13,11 +13,11 @@ TEST_GEN_PROGS := $(src_test:.c=)
>  TEST_GEN_PROGS_EXTENDED := true
>  
>  # Short targets:
> -$(TEST_GEN_PROGS): LDLIBS += -lcap
> +$(TEST_GEN_PROGS): LDLIBS += -lcap -lpthread
>  $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static
>  
>  include ../lib.mk
>  
>  # Targets with $(OUTPUT)/ prefix:
> -$(TEST_GEN_PROGS): LDLIBS += -lcap
> +$(TEST_GEN_PROGS): LDLIBS += -lcap -lpthread
>  $(TEST_GEN_PROGS_EXTENDED): LDFLAGS += -static
> -- 
> 2.48.1
> 

Reviewed-by: Günther Noack <gnoack3000@...il.com>