linux-kernel - Re: [PATCH v15 6/7] input: max77693: add max77705 haptic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABTCjFDOFjRtxvAjWy4dRcqrMKevVfH=No_-OzSvOUQAB1+M3A@mail.gmail.com>
Date: Fri, 17 Jan 2025 15:40:59 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>, Lee Jones <lee@...nel.org>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>, 
	Hans de Goede <hdegoede@...hat.com>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Purism Kernel Team <kernel@...i.sm>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-input@...r.kernel.org, 
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v15 6/7] input: max77693: add max77705 haptic support

пт, 17 янв. 2025 г. в 11:02, Krzysztof Kozlowski <krzk@...nel.org>:
>
> On 17/01/2025 09:01, Krzysztof Kozlowski wrote:
> >
> >>      case TYPE_MAX77843:
> >>              haptic->regmap_haptic = max77693->regmap;
> >>              break;
> >> @@ -407,6 +418,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(max77693_haptic_pm_ops,
> >>
> >>  static const struct platform_device_id max77693_haptic_id[] = {
> >>      { "max77693-haptic", },
> >> +    { "max77705-haptic", },
> >>      { "max77843-haptic", },
>
>
> ... and also drop this change, since compatible is going away and we
> expect matching by OF.
>
> >>      {},
> >>  };
> >> @@ -414,6 +426,7 @@ MODULE_DEVICE_TABLE(platform, max77693_haptic_id);
> >>
> >>  static const struct of_device_id of_max77693_haptic_dt_match[] = {
> >>      { .compatible = "maxim,max77693-haptic", },
> >> +    { .compatible = "maxim,max77705-haptic", },
> >
> > So the device looks fully compatible with max77693. Drop this change and
> > express compatibility with fallback.

Cannot be done, because config_reg is different.

-- 
Best regards and thanks for review,
Dzmitry