linux-kernel - Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93530df2-f1c0-4eb0-9955-90856570deea@axis.com>
Date: Fri, 17 Jan 2025 13:40:58 +0100
From: Jonas Andreasson <jonas.andreasson@...s.com>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
 kernel@...s.com
Subject: Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE

On 1/16/25 16:58, Mark Brown wrote:
> On Wed, Jan 15, 2025 at 10:55:22AM +0100, Jonas Andreasson wrote:
> 
>> +	if (!data || data->range == -1)
>> +		goto fallback;
> 
> ...
> 
>> +	return selector;
>> +
>> +fallback:
>> +	return regulator_map_voltage_pickable_linear_range(rdev, min_uV, max_uV);
> 
> You could just have the return statement directly and avoid the goto
> which would make this easier to follow.

Hello.
Thanks for looking at my code!
That is a good point which I will fix.

Kind Regards,
Jonas