linux-kernel - Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501181152.D4FjGoUD-lkp@intel.com>
Date: Sat, 18 Jan 2025 11:18:57 +0800
From: kernel test robot <lkp@...el.com>
To: Jonas Andreasson <jonas.andreasson@...s.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	kernel@...s.com, Jonas Andreasson <jonas.andreasson@...s.com>
Subject: Re: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE

Hi Jonas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on adc218676eef25575469234709c2d87185ca223a]

url:    https://github.com/intel-lab-lkp/linux/commits/Jonas-Andreasson/regulator-TPS6287X-Use-min-max-uV-to-get-VRANGE/20250115-175832
base:   adc218676eef25575469234709c2d87185ca223a
patch link:    https://lore.kernel.org/r/20250115-tps-fix-v1-1-2bd7b316409d%40axis.com
patch subject: [PATCH] regulator: TPS6287X: Use min/max uV to get VRANGE
config: arc-randconfig-001-20250116 (https://download.01.org/0day-ci/archive/20250118/202501181152.D4FjGoUD-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250118/202501181152.D4FjGoUD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501181152.D4FjGoUD-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/regulator/tps6287x-regulator.c: In function 'tps6287x_i2c_probe':
>> drivers/regulator/tps6287x-regulator.c:203:56: warning: passing argument 2 of 'tps6287x_best_range' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     203 |         reg_data->range = tps6287x_best_range(&config, &tps6287x_reg);
         |                                                        ^~~~~~~~~~~~~
   drivers/regulator/tps6287x-regulator.c:59:88: note: expected 'struct regulator_desc *' but argument is of type 'const struct regulator_desc *'
      59 | static int tps6287x_best_range(struct regulator_config *config, struct regulator_desc *desc)
         |                                                                 ~~~~~~~~~~~~~~~~~~~~~~~^~~~


vim +203 drivers/regulator/tps6287x-regulator.c

   179	
   180	static int tps6287x_i2c_probe(struct i2c_client *i2c)
   181	{
   182		struct device *dev = &i2c->dev;
   183		struct regulator_config config = {};
   184		struct tps6287x_reg_data *reg_data;
   185		struct regulator_dev *rdev;
   186	
   187		reg_data = devm_kzalloc(dev, sizeof(struct tps6287x_reg_data), GFP_KERNEL);
   188	
   189		if (!reg_data)
   190			return -ENOMEM;
   191	
   192		config.regmap = devm_regmap_init_i2c(i2c, &tps6287x_regmap_config);
   193		if (IS_ERR(config.regmap)) {
   194			dev_err(dev, "Failed to init i2c\n");
   195			return PTR_ERR(config.regmap);
   196		}
   197	
   198		config.dev = dev;
   199		config.of_node = dev->of_node;
   200		config.init_data = of_get_regulator_init_data(dev, dev->of_node,
   201							      &tps6287x_reg);
   202	
 > 203		reg_data->range = tps6287x_best_range(&config, &tps6287x_reg);
   204	
   205		rdev = devm_regulator_register(dev, &tps6287x_reg, &config);
   206		if (IS_ERR(rdev)) {
   207			dev_err(dev, "Failed to register regulator\n");
   208			return PTR_ERR(rdev);
   209		}
   210	
   211		rdev->reg_data = (void *)reg_data;
   212		dev_dbg(dev, "Probed regulator\n");
   213	
   214		return 0;
   215	}
   216	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki