linux-kernel - Re: [PATCH v3] perf annotate: Prefer passing evsel to evsel->core.idx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173739761245.3950752.18015295807257633517.b4-ty@kernel.org>
Date: Mon, 20 Jan 2025 10:26:52 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Mark Rutland <mark.rutland@....com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>, 
 Kan Liang <kan.liang@...ux.intel.com>, Chen Ni <nichen@...as.ac.cn>, 
 Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, 
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v3] perf annotate: Prefer passing evsel to
 evsel->core.idx

On Fri, 17 Jan 2025 10:18:48 -0800, Ian Rogers wrote:

> An evsel idx may not be stable due to sorting, evlist removal,
> etc. Try to reduce it being part of APIs by explicitly passing the
> evsel in annotate code. Internally the code just reads evsel->core.idx
> so behavior is unchanged.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
Namhyung