linux-kernel - Re: [PATCH v3] perf bench: Fix undefined behavior in cmpworker()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173739761304.3950752.5970208244862437457.b4-ty@kernel.org>
Date: Mon, 20 Jan 2025 10:26:53 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, 
 Kuan-Wei Chiu <visitorckw@...il.com>
Cc: mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
 jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com, 
 kan.liang@...ux.intel.com, Ching-Chun Huang <jserv@...s.ncku.edu.tw>, 
 Chun-Ying Huang <chuang@...nycu.edu.tw>, linux-perf-users@...r.kernel.org, 
 linux-kernel@...r.kernel.org, James Clark <james.clark@...aro.org>, 
 stable@...r.kernel.org
Subject: Re: [PATCH v3] perf bench: Fix undefined behavior in cmpworker()

On Thu, 16 Jan 2025 19:08:42 +0800, Kuan-Wei Chiu wrote:

> The comparison function cmpworker() violates the C standard's
> requirements for qsort() comparison functions, which mandate symmetry
> and transitivity:
> 
> Symmetry: If x < y, then y > x.
> Transitivity: If x < y and y < z, then x < z.
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung