linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: avoid trying to get invalid block address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e1348cc-9b91-40f0-b740-d26530fac6ce@kernel.org>
Date: Mon, 20 Jan 2025 13:27:09 +0800
From: Chao Yu <chao@...nel.org>
To: Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net
Cc: chao@...nel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid trying to get invalid block
 address

On 1/18/25 06:09, Jaegeuk Kim via Linux-f2fs-devel wrote:
> In f2fs_new_inode(), if we fail to get a new inode, we go iput(), followed by
> f2fs_evict_inode(). If the inode is not marked as bad, it'll try to call
> f2fs_remove_inode_page() which tries to read the inode block given node id.
> But, there's no block address allocated yet, which gives a chance to access
> a wrong block address, if the block device has some garbage data in NAT table.
> 
> We need to make sure NAT table should have zero data for all the unallocated
> node ids, but also would be better to take this unnecessary path as well.
> Let's mark the faild inode as bad.
> 

Needs a fixes line?

Fixes: 0abd675e97e6 ("f2fs: support plain user/group quota")

Otherwise, it looks good to me.

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,

> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>   fs/f2fs/namei.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 57d46e1439de..a278c7da8177 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -341,6 +341,7 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap,
>   	trace_f2fs_new_inode(inode, err);
>   	dquot_drop(inode);
>   	inode->i_flags |= S_NOQUOTA;
> +	make_bad_inode(inode);
>   	if (nid_free)
>   		set_inode_flag(inode, FI_FREE_NID);
>   	clear_nlink(inode);