linux-kernel - Re: [PATCH rc] iommufd: Explicitize struct iommu_hwpt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z43mIgD55kU+9UAJ@nvidia.com>
Date: Sun, 19 Jan 2025 21:58:58 -0800
From: Nicolin Chen <nicolinc@...dia.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
CC: "jgg@...dia.com" <jgg@...dia.com>, "baolu.lu@...ux.intel.com"
	<baolu.lu@...ux.intel.com>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH rc] iommufd: Explicitize struct iommu_hwpt_pgfault padding

On Mon, Jan 20, 2025 at 05:44:27AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@...dia.com>
> > Sent: Saturday, January 18, 2025 10:37 AM
> > 
> > @@ -868,6 +868,7 @@ enum iommu_hwpt_pgfault_perm {
> >   * @pasid: Process Address Space ID
> >   * @grpid: Page Request Group Index
> >   * @perm: Combination of enum iommu_hwpt_pgfault_perm
> > + * @__reserved: Must be 0.
> 
> iommufd_fault_fops_read() doesn't follow this statement as
> hwpt_fault is on stack with that field uninitialized.

OK. I guess I should update the iommufd_fault_fops_read too.

Thanks
Nic