linux-kernel - Re: [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXFxSSm6cOkKprFrOcFzb1wZK1t3vRfooRZqEHDtGDb4A@mail.gmail.com>
Date: Mon, 20 Jan 2025 16:41:31 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Sam Creasey <sammy@...my.net>, linux-m68k@...ts.linux-m68k.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle_fault()

Hi Thorsten,

On Fri, 17 Jan 2025 at 13:06, Thorsten Blum <thorsten.blum@...ux.dev> wrote:
> Remove hard-coded strings by using the str_read_write() helper.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k tree for v6.15.

> --- a/arch/m68k/sun3/mmu_emu.c
> +++ b/arch/m68k/sun3/mmu_emu.c
> @@ -371,7 +372,7 @@ int mmu_emu_handle_fault (unsigned long vaddr, int read_flag, int kernel_fault)
>
>  #ifdef DEBUG_MMU_EMU
>         pr_info("%s: vaddr=%lx type=%s crp=%p\n", __func__, vaddr,
> -               read_flag ? "read" : "write", crp);
> +               str_read_write(read_flag), crp);

You haven't really tested this with DEBUG_MMU_EMU enabled, have you?
Fix sent.

>  #endif
>
>         segment = (vaddr >> SUN3_PMEG_SIZE_BITS) & 0x7FF;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds