linux-kernel - Re: [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E7F49FB4-6DDF-47EA-97CA-8DFDC0D2F76C@linux.dev>
Date: Sat, 1 Feb 2025 17:37:26 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Sam Creasey <sammy@...my.net>,
 linux-m68k@...ts.linux-m68k.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k: sun3: Use str_read_write() helper in
 mmu_emu_handle_fault()

On 20. Jan 2025, at 16:41, Geert Uytterhoeven wrote:
>> --- a/arch/m68k/sun3/mmu_emu.c
>> +++ b/arch/m68k/sun3/mmu_emu.c
>> @@ -371,7 +372,7 @@ int mmu_emu_handle_fault (unsigned long vaddr, int read_flag, int kernel_fault)
>> 
>> #ifdef DEBUG_MMU_EMU
>>        pr_info("%s: vaddr=%lx type=%s crp=%p\n", __func__, vaddr,
>> -               read_flag ? "read" : "write", crp);
>> +               str_read_write(read_flag), crp);
> 
> You haven't really tested this with DEBUG_MMU_EMU enabled, have you?
> Fix sent.

Sorry, I missed this question.

I compile-tested it with DEBUG_MMU_EMU, but ignored the pr_info() error
you fixed in [1].

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/b1d12a1d24b4aea9f98d905383ba932b2dc382e6.1737387419.git.geert@linux-m68k.org/