linux-kernel - Re: [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d1d83b8-e3b6-4719-862f-3606d1783e73@genexis.eu>
Date: Mon, 20 Jan 2025 16:46:35 +0100
From: Benjamin Larsson <benjamin.larsson@...exis.eu>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
 ansuelsmth@...il.com, lorenzo@...nel.org, krzk+dt@...nel.org,
 gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles

On 2025-01-20 16:03, Krzysztof Kozlowski wrote:
> On 20/01/2025 13:59, Benjamin Larsson wrote:
>> On 2025-01-20 08:57, Krzysztof Kozlowski wrote:
>>> On Sun, Jan 19, 2025 at 02:01:04PM +0100, Benjamin Larsson wrote:
>>>> The Airoha SoC family have a mostly 16550-compatible UART
>>>> and High-Speed UART hardware with the exception of custom
>>>> baud rate settings register.
>>>>
>>>> Signed-off-by: Benjamin Larsson <benjamin.larsson@...exis.eu>
>>>> ---
>>>>    Documentation/devicetree/bindings/serial/8250.yaml | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
>>>> index 692aa05500fd..2fbb972e5460 100644
>>>> --- a/Documentation/devicetree/bindings/serial/8250.yaml
>>>> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
>>>> @@ -63,6 +63,8 @@ properties:
>>>>          - const: mrvl,pxa-uart
>>>>          - const: nuvoton,wpcm450-uart
>>>>          - const: nuvoton,npcm750-uart
>>>> +      - const: airoha,airoha-uart
>>>> +      - const: airoha,airoha-hsuart
>>> I assume you placed it matching existing order (kind of alphabetical for
>>> compatibles with vendors)?
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi, I placed it after nuvoton that was the most recent addition to the
>> serial8250_config uart_config[] table that was also added to the
> But wasn't nuvoton placed in specific, ordered place?

Well not really as wpcm450-uart is placed before npcm750-uart in 
8250.yaml. But I will move the entries to below ns16850 in the next 
revision to keep the vendor list in alphabetical order.


>
>> 8250.yaml binding. IIRC I noted that there was no clear order in the
>> binding list. So the placement could be considered as random. If another
>> place is better I can move it for the next version of the patch.
> Entries with vendor look to me fully ordered by name.
>
> Best regards,
> Krzysztof

MvH

Benjamin Larsson