linux-kernel - Re: [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d515426-78d0-445a-aaad-a08ef7e36c86@kernel.org>
Date: Mon, 20 Jan 2025 17:44:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Benjamin Larsson <benjamin.larsson@...exis.eu>
Cc: linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
 ansuelsmth@...il.com, lorenzo@...nel.org, krzk+dt@...nel.org,
 gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: serial: 8250: Add Airoha compatibles

On 20/01/2025 16:46, Benjamin Larsson wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
>>>>> index 692aa05500fd..2fbb972e5460 100644
>>>>> --- a/Documentation/devicetree/bindings/serial/8250.yaml
>>>>> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
>>>>> @@ -63,6 +63,8 @@ properties:
>>>>>          - const: mrvl,pxa-uart
>>>>>          - const: nuvoton,wpcm450-uart
>>>>>          - const: nuvoton,npcm750-uart
>>>>> +      - const: airoha,airoha-uart
>>>>> +      - const: airoha,airoha-hsuart
>>>> I assume you placed it matching existing order (kind of alphabetical for
>>>> compatibles with vendors)?
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> Hi, I placed it after nuvoton that was the most recent addition to the
>>> serial8250_config uart_config[] table that was also added to the
>> But wasn't nuvoton placed in specific, ordered place?
> 
> Well not really as wpcm450-uart is placed before npcm750-uart in 

Uh, indeed. :/

> 8250.yaml. But I will move the entries to below ns16850 in the next 
> revision to keep the vendor list in alphabetical order.

Best regards,
Krzysztof