linux-kernel - Re: mei modalias files missing device name and newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sa6wmeoy3vy.fsf@hjemme.reinholdtsen.name>
Date: Tue, 21 Jan 2025 09:20:33 +0100
From: Petter Reinholdtsen <pere@...ian.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, lewart3@...il.com
Cc: Alexander Usyskin <alexander.usyskin@...el.com>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: mei modalias files missing device name and newline

[Greg Kroah-Hartman]
> There's no "requirement" that modalias sysfs files have to have a
> trailing newline, so why is this considered "missing"?

This all started when it was discovered that after more than 8 years,
this one liner no longer worked as well as it used to:

  cat $(find /sys/devices -name modalias) | sort -u

> Not all, most.  If you want them all to, then we must sweep the whole
> tree and fix them up.  And then deal with any fallout where that
> happens to break things :)

>From my perspective, as the author of the isenkram package, it was the
introduction of entries without newlines that broke things, not the
other way around.

-- 
Happy hacking
Petter Reinholdtsen