linux-kernel - Re: mei modalias files missing device name and newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025012120-dusk-remnant-da88@gregkh>
Date: Tue, 21 Jan 2025 09:22:56 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Petter Reinholdtsen <pere@...ian.org>
Cc: lewart3@...il.com, Alexander Usyskin <alexander.usyskin@...el.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: mei modalias files missing device name and newline

On Tue, Jan 21, 2025 at 09:20:33AM +0100, Petter Reinholdtsen wrote:
> [Greg Kroah-Hartman]
> > There's no "requirement" that modalias sysfs files have to have a
> > trailing newline, so why is this considered "missing"?
> 
> This all started when it was discovered that after more than 8 years,
> this one liner no longer worked as well as it used to:
> 
>   cat $(find /sys/devices -name modalias) | sort -u
> 
> > Not all, most.  If you want them all to, then we must sweep the whole
> > tree and fix them up.  And then deal with any fallout where that
> > happens to break things :)
> 
> >From my perspective, as the author of the isenkram package, it was the
> introduction of entries without newlines that broke things, not the
> other way around.

So this file has always not had a newline on the end?

Anyway, I'm not objecting to the change, but it needs to be submitted in
a format we can apply it in, AND all other modalias files need to be
fixed up as well to provide a \n on the end.  The first one I found
turned out not to have that, so out of a "random sample" that was either
a lucky guess, or a sign that there is no consistancy here at all.

thanks,

greg k-h