linux-kernel - Re: [PATCH v2 2/3] mtd: rawnand: cadence: use dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed0wpk6h.fsf@bootlin.com>
Date: Tue, 21 Jan 2025 10:53:26 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: niravkumar.l.rabara@...el.com
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  linux@...blig.org,  Shen Lichuan
 <shenlichuan@...o.com>,  Jinjie Ruan <ruanjinjie@...wei.com>,
  u.kleine-koenig@...libre.com,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: cadence: use dma_map_resource for
 sdma address

Hello,

On 16/01/2025 at 11:21:53 +08, niravkumar.l.rabara@...el.com wrote:

> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
>
> Map the slave DMA I/O address using dma_map_resource.
> When ARM SMMU is enabled, using a direct physical address of SDMA results
> in DMA transaction failure.

It is in general a better practice anyway. Drivers should be portable
and always remap resources.

> Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
> Cc: stable@...r.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>

Thanks,
Miquèl