linux-kernel - Re: [PATCH v2 3/3] mtd: rawnand: cadence: fix incorrect dev context in dma_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xm8pk4n.fsf@bootlin.com>
Date: Tue, 21 Jan 2025 10:54:32 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: niravkumar.l.rabara@...el.com
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  linux@...blig.org,  Shen Lichuan
 <shenlichuan@...o.com>,  Jinjie Ruan <ruanjinjie@...wei.com>,
  u.kleine-koenig@...libre.com,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  stable@...r.kernel.org
Subject: Re: [PATCH v2 3/3] mtd: rawnand: cadence: fix incorrect dev context
 in dma_unmap_single

Hello,

On 16/01/2025 at 11:21:54 +08, niravkumar.l.rabara@...el.com wrote:

> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
>
> dma_map_single is using dma_dev->dev, however dma_unmap_single
> is using cdns_ctrl->dev, which is incorrect.
> Used the correct device context dma_dev->dev for dma_unmap_single.

I guess on is the physical/bus device and the other the framework
device? It would be nice to clarify this in the commit log.

> Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
> Cc: stable@...r.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>

Thanks,
Miquèl