linux-kernel - RE: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR05MB98106EAAB928CF87A4A1C6E783E62@AS8PR05MB9810.eurprd05.prod.outlook.com>
Date: Tue, 21 Jan 2025 10:23:20 +0000
From: Maarten Brock <Maarten.Brock@...ls.nl>
To: Andre Werner <andre.werner@...tec-electronic.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jirislaby@...nel.org" <jirislaby@...nel.org>, "hvilleneuve@...onoff.com"
	<hvilleneuve@...onoff.com>, "andy@...nel.org" <andy@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"lech.perczak@...lingroup.com" <lech.perczak@...lingroup.com>
Subject: RE: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior

> From: Andre Werner <andre.werner@...tec-electronic.com>
> 
> The logical meaning of the previous version is wrong due to a typo.
> 
> If the IRQ equals 0, no interrupt pin is available and polling mode
> shall be used.
> 
> Additionally, this fix adds a check for IRQ < 0 to increase robustness,
> because documentation still says that negative IRQ values cannot be
> absolutely ruled-out.
> 
> Fixes: 104c1b9dde9d859dd01bd2d ("serial: sc16is7xx: Add polling mode if no IRQ
> pin is available")
> 
> Signed-off-by: Andre Werner <andre.werner@...tec-electronic.com>

Reviewed-by: Maarten Brock <maarten.brock@...ls.nl>

Maarten