linux-kernel - RE: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB657573FA8C1CA294A5324F21FCE12@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Wed, 22 Jan 2025 17:46:14 +0000
From: Avri Altman <Avri.Altman@....com>
To: Manivannan Sadhasivam <manisadhasivam.linux@...il.com>
CC: "Martin K . Petersen" <martin.petersen@...cle.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Bart Van
 Assche <bvanassche@....org>, Can Guo <cang@....qualcomm.com>,
	"quic_ziqichen@...cinc.com" <quic_ziqichen@...cinc.com>
Subject: RE: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

 
> + Ziqi
> 
> On Wed, Jan 22, 2025 at 04:36:05PM +0200, Avri Altman wrote:
> > This commit moves the clock gating sysfs entries from `ufshcd.c` to
> > `ufs-sysfs.c` where it belongs. This change improves the organization
> > of the code by consolidating all sysfs-related code into a single file.
> >
> > The `clkgate_enable` and `clkgate_delay_ms` attributes are now defined
> > and managed in `ufs-sysfs.c`, and the corresponding initialization and
> > removal functions in `ufshcd.c` are removed.
> >
> > No functional change.
> >
> > Signed-off-by: Avri Altman <avri.altman@....com>
> 
> While this patch is useful, you should also consider adding the ABI
> documentation for these. I did share the comment to another patch that
> touches this part of the code:
> https://lore.kernel.org/linux-scsi/20250119074823.lnlppdpsfnkz7onx@thinkpad/
> 
> Maybe it is relevant to add the documentation together with this patch.
Thanks.
Ziqi already beat me - https://www.spinics.net/lists/linux-scsi/msg202516.html

Thanks,
Avri

> 
> - Mani
> 
> --
> மணிவண்ணன் சதாசிவம்